The first time I posted about this was after I hastily  assembled a github/buildbot integration.

--help of github_buildbot.py

I knew then that I wanted to take a few more passes to clean it up.  I did that with the help of Dan over the weekend.

Now it’s much better.  If you’re interested in the changes, you can see a dramatic difference by viewing the diff.

However, the easiest way to see the newly refactored code is by looking at ./contrib/github_buildbot.py.

One of the best new features about the new code is it’s ability to control it from command line parameters.

It’s also sporting a nice amount of refactored code, which means we deleting a lot of overly complicated code. Two things made that possible, Dan and Github’s service hook in JSON.

When the local directory is created, it is no longer a working directory with a branch checked out.  Now the buildmaster’s local repository is just a bare clone (thanks Igor). I added documentation and cleaned things up with pylint (which I’ll be blogging about my experiences with that shortly) to be more inline with PEP 8.

Finally and most importantly, Dan and I fixed a “changes” bug that would repeat the commits from the JSON n+1 more times.